feat: 지원자 현황 확인 디자인 구현#596
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f26bdb3406
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!prev || prev.applicants.length < scoreSheet.applicants.length) { | ||
| scoreSheetMap.set(key, scoreSheet); |
There was a problem hiding this comment.
When a university appears in more than one preference array, this keeps only the sheet with the largest single-preference applicant list and drops applicants from the other preferences. The redesigned list no longer has per-preference tabs, and the new detail page explicitly merges matches across choices, so a school with 3 first-choice and 2 second-choice applicants is shown as 3 in the list/sort/banner but 5 on the detail page. Merge applicant arrays per university instead of selecting one sheet.
Useful? React with 👍 / 👎.
| <button | ||
| type="button" | ||
| className="flex size-10 items-center justify-center rounded-full border border-white/80 bg-white/90 text-primary shadow-sm backdrop-blur-sm" | ||
| aria-label="관심 대학" |
There was a problem hiding this comment.
On the mobile application university detail page, this renders an enabled “관심 대학” button with no onClick handler or disabled state. Any user tapping the heart gets no state change or feedback, which makes the primary action look broken; either connect it to the existing wish-list behavior or avoid rendering it until it is supported.
Useful? React with 👍 / 👎.
1 participant
관련 이슈
작업 내용
university-web대학 상세와 지원자 현황 상세에서 함께 쓸 수 있도록MobileHeroDetailShell을@solid-connect/ui에 추가했습니다.web,university-webTailwind content/transpile 설정을 보강했습니다.검증
git diff --check@solid-connect/weblint, typecheck@solid-connect/university-weblint, typecheck@solid-connect/adminlint, typecheck@solid-connect/weblint, typecheck, build@solid-connect/university-weblint, typecheck, build@solid-connect/adminlint, typecheck, build@solid-connect/uilint/typecheck 통과/university/application모바일/데스크톱 렌더 확인/university/application/[universityName]모바일/데스크톱 렌더 확인university-web대학 상세 모바일/데스크톱 렌더 및 공통 hero sheet 적용 확인참고
feat/desktop-mode-pocPR(feat: 데스크톱 최적화 레이아웃 적용 #576)에 섞이지 않도록 해당 브랜치를 base로 둔 stacked PR입니다.main으로 변경할 수 있습니다.